Convert AspNetCore transport pkgproj to Pack task by ViktorHofer · Pull Request #56674 · dotnet/runtime

ViktorHofer · 2021-07-31T21:31:02Z

Converting the Microsoft.AspNetCore.Internal.Transport package to a proj
file which uses the NuGet Pack task.

Also moving some more packaging related targets into packaging.targets.

Diff: https://www.diffchecker.com/3qVruSQz

ghost · 2021-07-31T21:31:08Z

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Converting the Microsoft.AspNetCore.Internal.Transport package to a proj
file which uses the NuGet Pack task.

Also moving some more packaging related targets into packaging.targets.

Author:	ViktorHofer
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

Converting the Microsoft.AspNetCore.Internal.Transport package to a proj file which uses the NuGet Pack task. Also moving some more packaging related targets into packaging.targets.

Anipik

Can you add the nuspec diff here as well ?

ViktorHofer · 2021-08-02T18:50:26Z

Just added it to the top post. As the package doesn't have any dependencies it doesn't really tell much though.

ViktorHofer · 2021-08-02T18:53:30Z

Many unrelated failures because of flakiness in the test infrastructure. Merging.

safern

LGTM

Anipik · 2021-08-02T19:01:17Z

Diff: https://www.diffchecker.com/3qVruSQz

the diff here shows no files in the package.

ViktorHofer · 2021-08-02T19:04:33Z

A nuspec generated by the NuGet Pack task doesn't list any files by design. I compared the files locally and those match.

Anipik · 2021-08-02T19:13:58Z

A nuspec generated by the NuGet Pack task doesn't list any files by design. I compared the files locally and those match.

the extensions package use the nuget pack but still has the files

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>Microsoft.Extensions.DependencyInjection.Abstractions</id>
    <version>6.0.0-dev</version>
    <authors>Microsoft</authors>
    <license type="expression">MIT</license>
    <licenseUrl>https://licenses.nuget.org/MIT</licenseUrl>
    <icon>Icon.png</icon>
    <projectUrl>https://dot.net/</projectUrl>
    <description>Abstractions for dependency injection.

Commonly Used Types:
Microsoft.Extensions.DependencyInjection.IServiceCollection</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <repository type="git" url="https://github.com/dotnet/runtime" commit="0000000000000000000000000000000000000000" />
    <dependencies>
      <group targetFramework=".NETFramework4.6.1">
        <dependency id="Microsoft.Bcl.AsyncInterfaces" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Threading.Tasks.Extensions" version="4.5.4" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="Microsoft.Bcl.AsyncInterfaces" version="6.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.Threading.Tasks.Extensions" version="4.5.4" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.1" />
    </dependencies>
  </metadata>
  <files>
    <file src="C:\git\runtime\artifacts\bin\Microsoft.Extensions.DependencyInjection.Abstractions\net461-Debug\Microsoft.Extensions.DependencyInjection.Abstractions.dll" target="lib\net461\Microsoft.Ext
    <file src="C:\git\runtime\artifacts\bin\Microsoft.Extensions.DependencyInjection.Abstractions\netstandard2.0-Debug\Microsoft.Extensions.DependencyInjection.Abstractions.dll" target="lib\netstandard2
    <file src="C:\git\runtime\artifacts\bin\Microsoft.Extensions.DependencyInjection.Abstractions\netstandard2.1-Debug\Microsoft.Extensions.DependencyInjection.Abstractions.dll" target="lib\netstandard2
    <file src="C:\Users\anagniho\.nuget\packages\microsoft.private.intellisense\5.0.0-preview-20201009.2\IntellisenseFiles\net\1033\Microsoft.Extensions.DependencyInjection.Abstractions.xml" target="lib
    <file src="C:\Users\anagniho\.nuget\packages\microsoft.private.intellisense\5.0.0-preview-20201009.2\IntellisenseFiles\net\1033\Microsoft.Extensions.DependencyInjection.Abstractions.xml" target="lib
    <file src="C:\Users\anagniho\.nuget\packages\microsoft.private.intellisense\5.0.0-preview-20201009.2\IntellisenseFiles\net\1033\Microsoft.Extensions.DependencyInjection.Abstractions.xml" target="lib
    <file src="C:\git\runtime\eng\useSharedDesignerContext.txt" target="useSharedDesignerContext.txt" />
    <file src="C:\Users\anagniho\.nuget\packages\microsoft.dotnet.arcade.sdk\6.0.0-beta.21370.12\tools\Assets\DotNetPackageIcon.png" target="Icon.png" />
    <file src="C:\git\runtime\LICENSE.TXT" target="LICENSE.TXT" />
    <file src="C:\git\runtime\THIRD-PARTY-NOTICES.TXT" target="THIRD-PARTY-NOTICES.TXT" />
  </files>
</package>

ViktorHofer · 2021-08-02T19:22:36Z

I don't know which NuGet.exe or dotnet sdk you are using but neither the tools on my machine nor the official builds produce nuspecs with files in it:

Package: https://dnceng.visualstudio.com/public/_packaging?_a=package&feed=dotnet6&package=Microsoft.Extensions.DependencyInjection.Abstractions&protocolType=NuGet&version=6.0.0-rc.1.21402.3

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>Microsoft.Extensions.DependencyInjection.Abstractions</id>
    <version>6.0.0-rc.1.21402.3</version>
    <authors>Microsoft</authors>
    <owners></owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <license type="expression">MIT</license>
    <icon>Icon.png</icon>
    <projectUrl>https://dot.net/</projectUrl>
    <description>Abstractions for dependency injection.

Commonly Used Types:
Microsoft.Extensions.DependencyInjection.IServiceCollection</description>
    <releaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</releaseNotes>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <serviceable>true</serviceable>
    <repository type="git" url="https://github.com/dotnet/runtime" commit="aa4290f3f0aadf86882a439d124db3215851760b" />
    <dependencies>
      <group targetFramework=".NETFramework4.6.1">
        <dependency id="Microsoft.Bcl.AsyncInterfaces" version="6.0.0-rc.1.21402.3" exclude="Build,Analyzers" />
        <dependency id="System.Threading.Tasks.Extensions" version="4.5.4" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net6.0" />
      <group targetFramework=".NETStandard2.0">
        <dependency id="Microsoft.Bcl.AsyncInterfaces" version="6.0.0-rc.1.21402.3" exclude="Build,Analyzers" />
        <dependency id="System.Threading.Tasks.Extensions" version="4.5.4" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.1" />
    </dependencies>
  </metadata>
</package>

safern · 2021-08-02T20:40:55Z

I believe @Anipik might be looking at the nuspec generated by the task in order to generate the nupkg and the one that doesn't contain the files is the one inside the final package?

Anipik · 2021-08-02T20:58:08Z

I believe @Anipik might be looking at the nuspec generated by the task in order to generate the nupkg and the one that doesn't contain the files is the one inside the final package

correct

ViktorHofer · 2021-08-02T21:05:06Z

I believe @Anipik might be looking at the nuspec generated by the task in order to generate the nupkg and the one that doesn't contain the files is the one inside the final package?

Thanks for clarifying, that makes sense. I don't think diffing that intermediate nuspec is useful as it doesn't represent the final nuspec which is part of the package. Also the intermediate one if machine specific (ie absolute paths) and hence quite hard to diff.

safern · 2021-08-03T04:25:04Z

This change introduced a build error when building some of the extensions package. i.e:

C:\repos\runtime\src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.
C:\repos\runtime\src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.

Should repro with:

 dotnet pack .\src\libraries\Microsoft.Extensions.DependencyModel\src\

The interesting thing is that it doesn't fail the build, that's why the build was green.

https://dev.azure.com/dnceng/public/_build/results?buildId=1272285&view=logs&j=81a0f8c2-d4db-561f-9b8e-3f045280d7fe&t=2a104984-c43b-5b93-1361-6bd8a1e96b04&l=2141

safern · 2021-08-03T05:02:08Z

Seems to be related to ordering, haven't figured out why, but packaging.targets is imported afterwards. If I move what was moved from Directory.Build.targets down, back to its original location, everything works fine.

ViktorHofer · 2021-08-03T05:11:41Z

Thanks for reporting. I will try to fix this immediately. Interestingly this is also showing in my other PR (windows compat pack).

safern · 2021-08-03T05:14:26Z

I see. The problem is that these properties:

<BeforePack>IncludeAnalyzersInPackage;$(BeforePack)</BeforePack>
<BuildAnalyzerReferences>$(BuildProjectReferences)</BuildAnalyzerReferences>
<BuildAnalyzerReferences Condition="'$(BuildingInsideVisualStudio)' == 'true'">false</BuildAnalyzerReferences>

Where set unconditionally and now are set conditionally only when '$(IsPackable)' == 'true'. However not all project have moved to use the pack task, and in this case System.Text.Json which references an analyzer project, doesn't set IsPackable == true, so BuildAnalyzerReferences is not set, hence the ProjectReference we add for the AnalyzerReference is built as that property is empty by default. So when ProjectRefernces are resolved GetTargetPath is invoked on it.

ViktorHofer requested a review from Anipik July 31, 2021 21:31

ghost added the area-Infrastructure-libraries label Jul 31, 2021

Convert AspNetCore transport pkgproj to Pack task

156e0e1

Converting the Microsoft.AspNetCore.Internal.Transport package to a proj file which uses the NuGet Pack task. Also moving some more packaging related targets into packaging.targets.

ViktorHofer force-pushed the AspNetCoreInternalPackage branch from a9d23fd to 156e0e1 Compare July 31, 2021 21:35

Update Microsoft.AspNetCore.Internal.Transport.proj

d143115

ViktorHofer mentioned this pull request Aug 1, 2021

Port projects from pkgproj to dotnet pack #53202

Closed

58 tasks

Anipik approved these changes Aug 2, 2021

View reviewed changes

ViktorHofer merged commit f440371 into dotnet:main Aug 2, 2021

ViktorHofer deleted the AspNetCoreInternalPackage branch August 2, 2021 18:53

safern reviewed Aug 2, 2021

View reviewed changes

safern mentioned this pull request Aug 3, 2021

Fix build error when building some packages #56767

Merged

karelz mentioned this pull request Aug 30, 2021

Test failure: Send_0ByteSend_Success #58356

Closed

ghost locked as resolved and limited conversation to collaborators Sep 2, 2021

Uh oh!

Conversation

ViktorHofer commented Jul 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 31, 2021

Uh oh!

Anipik left a comment

Choose a reason for hiding this comment

Uh oh!

ViktorHofer commented Aug 2, 2021

Uh oh!

ViktorHofer commented Aug 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

safern left a comment

Choose a reason for hiding this comment

Uh oh!

Anipik commented Aug 2, 2021

Uh oh!

ViktorHofer commented Aug 2, 2021

Uh oh!

Anipik commented Aug 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ViktorHofer commented Aug 2, 2021

Uh oh!

safern commented Aug 2, 2021

Uh oh!

Anipik commented Aug 2, 2021

Uh oh!

ViktorHofer commented Aug 2, 2021

Uh oh!

safern commented Aug 3, 2021

Uh oh!

safern commented Aug 3, 2021

Uh oh!

ViktorHofer commented Aug 3, 2021

Uh oh!

safern commented Aug 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ViktorHofer commented Jul 31, 2021 •

edited

Loading

ViktorHofer commented Aug 2, 2021 •

edited

Loading

Anipik commented Aug 2, 2021 •

edited

Loading